-
-
Notifications
You must be signed in to change notification settings - Fork 95
add TransDB to projects section #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TransDB to projects section #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Divyamsharma-18, thank you for your work on this change.
Yes, it would be best to have the changes with no formatting changes. I have a minor change suggestion about alt test for the project logo (I have no idea why other alt texts are like that. 😓 )
index.html
Outdated
encourage diversity and inclusion at those events.</p> | ||
</a> | ||
<a class="col-sm-6 col-md-4 p-4" href="https://transdb.org" target="_blank" rel="noopener"> | ||
<img alt="Trans*DB image link" title="Trans*DB" src="img/projects/transdb.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better alt would be TransDB logo
Hey @Roshanjossey! I've made the suggested changes:
Let me know if there's anything else to update. Danke schön for your kind feedback! 🙌 |
Hi @Divyamsharma-18, I still see only one commit in this pull request. Maybe it wasn't pushed. |
Hi @Roshanjossey! I've now pushed the updated commit with all the suggested changes: ✅ Updated the (Sorry for the delay — I had accidentally committed to the wrong branch, but it's all fixed now 😊) Let me know if anything else needs tweaking. Danke schön! |
Hey @Roshanjossey! Just wanted to follow up on the earlier comment above regarding the PR and the updates. Let me know if anything else is needed from my side — happy to refine things further! 😊 |
Hey @Roshanjossey! No rush at all, just wanted to make sure it didn’t get lost in the queue 😊 |
Hi @Divyamsharma-18, thank you for following up. I still see formatting changes in the PR.
I think it's the first commit that's causing this. second commit looks correct. Also, I'm waiting for a go ahead from a maintainer in TransDB team |
c0e667f
to
075659f
Compare
Hey @Roshanjossey, |
thanks for the work @Divyamsharma-18 and for your support @Roshanjossey 👏 |
📌 What I did
🔗 Issue Reference
Closes #173
🖼️ Preview
🧾 Note
My code editor auto-formatted the file, which caused the large diff count (+582 −484).
The actual content change is limited to the new TransDB project card addition.
Let me know if you'd prefer a version with minimal formatting changes — happy to update!