Allow static pin to move off the map #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy5
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our application, the static pin is used as a cursor for selecting content.
When the content is near the edge of the zoomed image, we need the coordinates back from the library in order to select it –
nulldoesn't give us anything here.Unfortunately this means – the change here is that it's up to the client code to determine whether the point is valid for its use cases. I think this is a reasonable change – we shouldn't have any opinion about whether a point is valid or not. In some instances, points are only valid when they're on the content image – but not in all instances, especially for the static pin.
This can be a prop if it really needs to be.