Skip to content

Conversation

elliottkember
Copy link
Collaborator

@elliottkember elliottkember commented Oct 17, 2024

In our application, the static pin is used as a cursor for selecting content.

When the content is near the edge of the zoomed image, we need the coordinates back from the library in order to select it – null doesn't give us anything here.

Unfortunately this means – the change here is that it's up to the client code to determine whether the point is valid for its use cases. I think this is a reasonable change – we shouldn't have any opinion about whether a point is valid or not. In some instances, points are only valid when they're on the content image – but not in all instances, especially for the static pin.

This can be a prop if it really needs to be.

Copy link

@dmurphy5 dmurphy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me, a point that's off the sheet is better than null.

@elliottkember elliottkember merged commit 2bff5b8 into master Oct 21, 2024
1 check passed
@elliottkember elliottkember deleted the elliott/static-pin-off-map branch October 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants