Add support for graphical consoles#640
Add support for graphical consoles#640steveb wants to merge 4 commits intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3e6f4be009d34ecfbfd18d037f86dbf5 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 24s |
63004fb to
2f9267c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df1715ed20f64daabd4f1d348b436699 ❌ openstack-k8s-operators-content-provider FAILURE in 9m 17s |
|
@steveb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
When the ironic spec graphicalConsoles is set to "Enabled" the following occurs: - a novncproxy container is added to the conductor pod - a route is added for users to access novncproxy URLs - conductor config is modified to enable graphical console drivers - [vnc] config enables the kubernetes container_provider Jira: OSPRH-20211
Currently graphical console pods (and related secrets) are created in the openstack namespace. This increases security risks in 2 ways: - Ironic service account is given access to secrets in the openstack namespace - Graphical console pods share network namespace with other ironic services Putting graphical console pods improves isolation with the rest of the control plane. A future enhancement could be to create a namespace per tenant to improve isolation of graphical console pods between tenants. Jira: OSPRH-20211
This removes irmc, idrac, ilo, and inspector from enabled interfaces as they have been removed upstream. This shouldn't land now but could be used as a starting point when RHOSO-19 development begins.
This can be removed once [1] is merged [1] openstack-k8s-operators/openstack-operator#1633
806c298 to
47e63f7
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bee9bf548f8b42089d281988ac283c47 ❌ openstack-k8s-operators-content-provider FAILURE in 10m 51s |
When the ironic spec graphicalConsoles is set to "Enabled" the following occurs:
Depends-On: openstack-k8s-operators/openstack-operator#1633
Jira: OSPRH-20211
[1] https://review.opendev.org/c/openstack/ironic/+/962242
Describe your changes
Jira Ticket Link
Jira:
Checklist before requesting a review
pre-commit run --all