Add rbac for ironic-operator creating namespaces#696
Add rbac for ironic-operator creating namespaces#696steveb wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The graphical consoles feature will create the namespace openstack-ironic-consoles which Ironic will use to create the graphical console pods. To do this, ironic-operator needs rbac rules to create and manage (not delete) namespaces. This is proposed as a standalone change because it needs to be packaged in the openstack-operator bundle before ironic-operator can use it. Jira: OSPRH-20211
|
@steveb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
wondering what's the architecture/need is to use a dedicated namespace for the console deployment. iiuc from checking the related pr, its gonna be one per ctlplane deployment namespace. so far we kept all deployments for a ctlplane of an env in a single namespace. |
Describe your changes
The graphical consoles feature will create the namespace openstack-ironic-consoles which Ironic will use to create the graphical console pods.
To do this, ironic-operator needs rbac rules to create and manage (not delete) namespaces. This is proposed as a standalone change because it needs to be packaged in the openstack-operator bundle before ironic-operator can use it.
For precedence of this change, openstack-operator has the ability to manage every aspect of namespaces: https://github.com/openstack-k8s-operators/openstack-operator/blob/main/config/rbac/role.yaml#L27-L32
Jira: OSPRH-20211
Checklist before requesting a review
pre-commit run --all