-
Notifications
You must be signed in to change notification settings - Fork 50
Add helpers for StatefulSet container merging, raw ConfigMaps, and preserved Secrets #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /* | ||
| Copyright 2026 Red Hat | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package statefulset | ||
|
|
||
| import ( | ||
| corev1 "k8s.io/api/core/v1" | ||
| ) | ||
|
|
||
| // MergeContainersByName merges desired container specs into existing containers | ||
| // matched by name. It starts from the desired container and preserves only the | ||
| // server-defaulted fields (TerminationMessagePath, TerminationMessagePolicy, | ||
| // ImagePullPolicy) from the existing container. All other fields come from the | ||
| // desired spec, which ensures that new fields added in future Kubernetes | ||
| // versions are not silently dropped. | ||
| // | ||
| // When container counts differ or a desired container name is not found in | ||
| // existing, the existing slice is replaced with the desired containers. | ||
| func MergeContainersByName(existing *[]corev1.Container, desired []corev1.Container) { | ||
| if len(*existing) != len(desired) { | ||
| *existing = desired | ||
| return | ||
| } | ||
|
|
||
| existingByName := make(map[string]int, len(*existing)) | ||
| for i := range *existing { | ||
| existingByName[(*existing)[i].Name] = i | ||
| } | ||
|
|
||
| for _, d := range desired { | ||
| idx, ok := existingByName[d.Name] | ||
| if !ok { | ||
| *existing = desired | ||
| return | ||
| } | ||
| // Preserve server-defaulted fields from the existing container | ||
| // only when the desired spec doesn't explicitly set them. | ||
| if d.ImagePullPolicy == "" { | ||
| d.ImagePullPolicy = (*existing)[idx].ImagePullPolicy | ||
| } | ||
| if d.TerminationMessagePath == "" { | ||
| d.TerminationMessagePath = (*existing)[idx].TerminationMessagePath | ||
| } | ||
| if d.TerminationMessagePolicy == "" { | ||
| d.TerminationMessagePolicy = (*existing)[idx].TerminationMessagePolicy | ||
| } | ||
| (*existing)[idx] = d | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we pass a secret, in above CM case, we pass name, namespace, data, lb. should we also pass a cm for CreateOrPatchRawConfigMap ?