[CPU] Setting parallel to tbb static partitioner or tbb auto partitoner by thread pool #30167
+1,420
−466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
wangleis
reviewed
Apr 17, 2025
praasz
reviewed
Apr 25, 2025
github-actions
bot
removed
category: Core
maxnick
reviewed
May 2, 2025
src/plugins/intel_cpu/src/nodes/executors/dnnl/dnnl_matmul_primitive.cpp
Outdated
Show resolved
Hide resolved
maxnick
reviewed
Sep 29, 2025
maxnick
reviewed
Oct 13, 2025
Comment on lines
16
to
19
| constexpr int default_multiplier = 32; | ||
| class ThreadPool; | ||
|
|
||
| class CpuParallel { |
There was a problem hiding this comment.
NIT. Could you please move it inside the class as a static field?
class CpuParallel {
public:
static constexpr int default_multiplier = 32;
public:
CpuParallel() = delete;
....
};There was a problem hiding this comment.
Ok moved it inside CpuParallel class.
Comment on lines
+69
to
+71
| template <typename T0, typename R, typename F> | ||
| [[nodiscard]] R cpu_parallel_sum(const T0& D0, const R& input, const F& func) const { | ||
| #if OV_THREAD == OV_THREAD_TBB_ADAPTIVE |
There was a problem hiding this comment.
Can we move all the cpu_parallel_... methods into the private section? Because with this design, the cpu_parallel_... methods and the parallel_... methods of the same class may be used interchangeably, which would introduce a mess into the code base. Better to avoid such a situation and use the uniform name convention.
There was a problem hiding this comment.
Yes, you are right, moved these functions into private section.
| // cpu stream executor for current graph | ||
| ov::threading::CPUStreamsExecutor::Ptr m_cpuStreamExecutor; | ||
| std::shared_ptr<CpuParallel> m_cpuParallel = nullptr; | ||
| // std::shared_ptr<ThreadPool> m_threadPool = nullptr; |
|
@sunxiaoxia2022 , could you please fix the CI errors? |
maxnick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: