- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.8k
[CPU] Use ITT regions API #31499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPU] Use ITT regions API #31499
Conversation
a5fec0c    to
    7e9b145      
    Compare
  
    ae09637    to
    0f3de31      
    Compare
  
            
          
                src/inference/src/cpp/core.cpp
              
                Outdated
          
        
      | CompiledModel Core::compile_model(const std::shared_ptr<const ov::Model>& model, | ||
| const std::string& device_name, | ||
| const AnyMap& config) { | ||
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this extra "Compile model" task since we already have a region
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                src/inference/src/cpp/core.cpp
              
                Outdated
          
        
      | } | ||
|  | ||
| CompiledModel Core::compile_model(const std::string& model_path, const AnyMap& config) { | ||
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this extra "Compile model" task since we already have a region
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                src/inference/src/cpp/core.cpp
              
                Outdated
          
        
      |  | ||
| #ifdef OPENVINO_ENABLE_UNICODE_PATH_SUPPORT | ||
| CompiledModel Core::compile_model(const std::wstring& model_path, const AnyMap& config) { | ||
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this extra "Compile model" task since we already have a region
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                src/inference/src/cpp/core.cpp
              
                Outdated
          
        
      | #endif | ||
|  | ||
| CompiledModel Core::compile_model(const std::string& model_path, const std::string& device_name, const AnyMap& config) { | ||
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this extra "Compile model" task since we already have a region
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                src/inference/src/cpp/core.cpp
              
                Outdated
          
        
      | CompiledModel Core::compile_model(const std::wstring& model_path, | ||
| const std::string& device_name, | ||
| const AnyMap& config) { | ||
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this extra "Compile model" task since we already have a region
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                src/inference/src/cpp/core.cpp
              
                Outdated
          
        
      | const ov::Tensor& weights, | ||
| const std::string& device_name, | ||
| const AnyMap& config) { | ||
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this extra "Compile model" task since we already have a region
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
        
          
                src/inference/src/cpp/core.cpp
              
                Outdated
          
        
      | CompiledModel Core::compile_model(const std::shared_ptr<const ov::Model>& model, | ||
| const RemoteContext& context, | ||
| const AnyMap& config) { | ||
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this extra "Compile model" task since we already have a region
| OV_ITT_SCOPED_TASK_BASE(ov::itt::domains::OV, "Compile model"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 (Approved)
Details:
-DENABLE_PROFILING_ITT=OFF/BASE/FULL)Tickets: