Skip to content

[Snippets] Switch TransformConvertToConvertTruncation and ConvertConstantsToScalars to ModelPass #32260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snippets] Switch TransformConvertToConvertTruncation and ConvertConstantsToScalars to ModelPass #32260

wants to merge 1 commit into from
+3 −13

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Sep 30, 2025 •
edited
Loading

Details:

  • TransformConvertToConvertTruncation is now a normal ov::pass::ModelPass and runs first in Subgraph::data_flow_transformations
  • ConvertConstantsToScalars is now a normal ov::pass::ModelPass and runs near the end of Subgraph::data_flow_transformations
  • Both passes are applied only to the Subgraph body
  • Removed the old TransformConvertToConvertTruncation registration from CommonOptimizations to avoid double application

Tickets:

  • N/A

@aobolensk aobolensk requested a review from a team as a code owner September 30, 2025 17:11
v-Golubev
v-Golubev reviewed Oct 1, 2025
View reviewed changes
src/common/snippets/src/op/subgraph.cpp
}

ov::snippets::pass::Manager manager(pass_config, "SnippetsDataFlowManager");
manager.register_pass<snippets::pass::TransformConvertToConvertTruncation>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConvertConstantsToScalars is called twice in the data flow pipeline. From the first glance, it looks redundant. Can we try to register it only as the last pass in the pipeline?

src/common/snippets/include/snippets/pass/convert_constants.hpp Outdated
* @ingroup snippets
*/
class ConvertConstantsToScalars : public ov::pass::MatcherPass {
class ConvertConstantsToScalars : public ov::pass::ModelPass {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both ConvertConstantsToScalars and TransformConvertToConvertTruncation should be MatcherPass, not ModelPass, since we work only with the target operation there

@v-Golubev
Copy link
Contributor

v-Golubev commented Oct 1, 2025 •
edited
Loading

Internal validation is required before the merge

@v-Golubev v-Golubev added this to the 2025.4 milestone Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-Golubev v-Golubev v-Golubev left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@v-Golubev v-Golubev

Labels

category: snippets do_not_merge do_not_review

Projects

None yet

Milestone

2025.4

Development

Successfully merging this pull request may close these issues.

3 participants

@aobolensk @v-Golubev @allnes