Skip to content

Conversation

@tiger100256-hu
Copy link
Contributor

@tiger100256-hu tiger100256-hu commented Oct 13, 2025

Details:

Tickets:

@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra category: transformations OpenVINO Runtime library - Transformations labels Oct 13, 2025
@yuxu42 yuxu42 requested a review from zhangYiIntel October 13, 2025 09:10
Signed-off-by: HU Yuan2 <[email protected]>
Signed-off-by: HU Yuan2 <[email protected]>
Signed-off-by: HU Yuan2 <[email protected]>
Signed-off-by: HU Yuan2 <[email protected]>
Signed-off-by: HU Yuan2 <[email protected]>
@github-actions github-actions bot removed the category: transformations OpenVINO Runtime library - Transformations label Oct 14, 2025
Copy link
Contributor

@zhangYiIntel zhangYiIntel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sink input is an optional parameter, if we decide to pass this parameter from SDPA cpu node to inside kernels, it's better to explicitly pass valid pointer/Plaintensor or nullptr/Plaintensor() to kernels to avoid misusage of this parameter.

@github-actions github-actions bot removed the category: build OpenVINO cmake script / infra label Oct 15, 2025
@tiger100256-hu tiger100256-hu changed the title [CPU] add support for sink input of SDPA [CPU][x86] add support for sink input of SDPA Oct 15, 2025
@tiger100256-hu tiger100256-hu marked this pull request as ready for review October 15, 2025 06:28
@tiger100256-hu tiger100256-hu requested review from a team as code owners October 15, 2025 06:28
Copy link
Contributor

@zhangYiIntel zhangYiIntel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuxu42 yuxu42 added this to the 2025.4 milestone Oct 17, 2025
Signed-off-by: HU Yuan2 <[email protected]>
@yuxu42
Copy link
Contributor

yuxu42 commented Oct 17, 2025

Hi @maxnick could you please take a review? Thanks!

Comment on lines -29 to +30
bool quant_key_by_channel);
bool quant_key_by_channel,
const ov::intel_cpu::PlainTensor& sink_input);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short comment about the purpose of this sink input and what should be set if there is no sink input.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already add comment, please help to check it, thanks

@maxnick
Copy link
Contributor

maxnick commented Oct 20, 2025

PR is waiting performance checks.

@maxnick maxnick added this pull request to the merge queue Oct 21, 2025
Merged via the queue into openvinotoolkit:master with commit 0cf1985 Oct 21, 2025
201 checks passed
@maxnick maxnick deleted the huyuan/sink_input branch October 21, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: CPU OpenVINO CPU plugin Code Freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants