Skip to content

[coverity, core] Fix high IE common issues 25.4 #32441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 24, 2025
Merged

[coverity, core] Fix high IE common issues 25.4 #32441

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
db0c809
CID-2425741, 2425714 dereference potentially null ptr
praasz Oct 15, 2025
1d279d6
CID-2425706 Dereference null field
praasz Oct 16, 2025
e7a520e
Update src/core/src/runtime/allocator.cpp
praasz Oct 16, 2025
ad25eb6
Fix using mock plugin in tests
praasz Oct 17, 2025
3e1dec6
Merge remote-tracking branch 'origin/master' into coverity/fix-high-i…
praasz Oct 17, 2025
d285433
Update MockPlugin to support set/get property without impl injection
praasz Oct 17, 2025
6577bea
Revert not required changes
praasz Oct 19, 2025
9a58dcd
ov::test::mock::plugin not throw on set_property
praasz Oct 19, 2025
7681c61
Try fix RegisterPlugin test
praasz Oct 20, 2025
a55a367
Try Fix RegisterPlugins test
praasz Oct 20, 2025
f35e22d
Use mutex when iterate over pluginRegistry
praasz Oct 22, 2025
6c913da
Fix set property for proxy plugin
praasz Oct 22, 2025
1fe2f4b
Merge branch 'master' into coverity/fix-high-ie-common-issues-25-4
mlukasze Oct 23, 2025
5367e47
Revert test changes in core threading changes
praasz Oct 23, 2025
00b55ba
Change timeout for unit test for Win (Debug)
praasz Oct 24, 2025
2af348a
Remove commented code
praasz Oct 24, 2025
635887e
Update vs2022_debug unit tests timeout
praasz Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/src/runtime/allocator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ bool Allocator::operator==(const Allocator& other) const {
if (_impl == other._impl) {
return true;
}
return _impl->is_equal(*other._impl);
return other._impl && other._impl && _impl->is_equal(*other._impl);
});
}

Expand Down
11 changes: 11 additions & 0 deletions src/core/tests/ov_default_allocator_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
#include "openvino/core/except.hpp"
#include "openvino/runtime/allocator.hpp"

namespace ov::test {
using ::testing::_;
using OVDefaultAllocatorTest = ::testing::Test;

TEST_F(OVDefaultAllocatorTest, notThrowOnZeroSize) {
Expand Down Expand Up @@ -59,3 +61,12 @@ TEST_F(OVDefaultAllocatorTest, canAllocate10KMemory) {
EXPECT_EQ(ptr[9999], 11);
allocator.deallocate(handle);
}

TEST_F(OVDefaultAllocatorTest, compareIfImplIsNull) {
auto a1 = ov::Allocator();
auto a2 = std::move(a1);

EXPECT_FALSE(a2 == a1);
OV_EXPECT_THROW(std::ignore = (a1 == a2), ov::Exception, _);
}
} // namespace ov::test
4 changes: 2 additions & 2 deletions src/inference/src/dev/plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const ov::Version ov::Plugin::get_version() const {
}

void ov::Plugin::set_property(const ov::AnyMap& config) {
m_ptr->set_property(config);
OV_PLUGIN_CALL_STATEMENT(m_ptr->set_property(config));
}

ov::SoPtr<ov::ICompiledModel> ov::Plugin::compile_model(const std::shared_ptr<const ov::Model>& model,
Expand Down Expand Up @@ -108,7 +108,7 @@ ov::SoPtr<ov::IRemoteContext> ov::Plugin::get_default_context(const AnyMap& para
}

ov::Any ov::Plugin::get_property(const std::string& name, const AnyMap& arguments) const {
return {m_ptr->get_property(name, arguments), {m_so}};
OV_PLUGIN_CALL_STATEMENT(return {m_ptr->get_property(name, arguments), {m_so}});
}

bool ov::Plugin::supports_model_caching(const ov::AnyMap& arguments) const {
Expand Down
Loading