Skip to content

Conversation

@MosCD3
Copy link
Contributor

@MosCD3 MosCD3 commented Nov 20, 2025

Summary of Changes

  • Refactor OpenID cred flow to have 2 step credential refresh instead of 1 full replacment step
  • Fix Orcestrator mock logger issues

Testing Instructions

Replace this text with detailed instructions on how to test the changes included in this PR.

Acceptance Criteria

Replace this text with the acceptance criteria that must be met for this PR to be approved.

Screenshots, videos, or gifs

Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A

Breaking change guide

Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • If applicable, added changeset(s)
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: e6824db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 22.68041% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.41%. Comparing base (7687f2c) to head (e6824db).

Files with missing lines Patch % Lines
.../src/modules/openid/refresh/refreshOrchestrator.ts 3.12% 31 Missing ⚠️
...odules/openid/hooks/useUpgradeExpiredCredential.ts 22.58% 24 Missing ⚠️
...rc/modules/openid/hooks/useExpiredNotifications.ts 57.89% 8 Missing ⚠️
.../src/components/listItems/NotificationListItem.tsx 16.66% 5 Missing ⚠️
...kages/core/src/modules/openid/refresh/registery.ts 0.00% 4 Missing ⚠️
.../src/modules/openid/hooks/useDeclineReplacement.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1717      +/-   ##
==========================================
- Coverage   53.69%   53.41%   -0.29%     
==========================================
  Files         304      305       +1     
  Lines       10830    10893      +63     
  Branches     3006     3014       +8     
==========================================
+ Hits         5815     5818       +3     
- Misses       4984     5026      +42     
- Partials       31       49      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MosCD3 MosCD3 marked this pull request as ready for review November 21, 2025 14:43
@MosCD3 MosCD3 requested a review from a team as a code owner November 21, 2025 14:43
@jleach jleach changed the title chore: Refactor and cleanup OpenID refresh flow chore: refactor and cleanup OpenID refresh flow Nov 21, 2025
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants