Skip to content

Conversation

@jamescmartinez
Copy link
Contributor

@jamescmartinez jamescmartinez commented Nov 18, 2025

This is a draft PR. There are likely still untested edge cases, so this was opened to review before merging since validateReplayOrder is easy to get wrong

Summary

Adds deterministic replay validation that detects & fails on step name/order mismatches during replay.

Changes

  • Workers throw NonDeterministicError when a workflow is replayed after a worker restart and the actual recorded step history does not match the expected/current sequence
  • Adds a ton of tests
  • Adds a short architecture summary to the docs

Copilot AI review requested due to automatic review settings November 18, 2025 20:45
@jamescmartinez jamescmartinez added enhancement New feature or request help wanted Extra attention is needed labels Nov 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jamescmartinez
Copy link
Contributor Author

CI/Copilot/etc failing with this error. I'll check back later

remote: Internal Server Error
Error: fatal: unable to access 'https://github.com/openworkflowdev/openworkflow/': The requested URL returned error: 500

@jamescmartinez jamescmartinez removed enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jamescmartinez jamescmartinez marked this pull request as draft November 21, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants