-
Notifications
You must be signed in to change notification settings - Fork 98
rq: add a garbage collector to the worker #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
efahl
wants to merge
1
commit into
openwrt:main
Choose a base branch
from
efahl:clean-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| __version__ = "0.0.0" | ||
|
|
||
| from .rq import GCWorker as GCWorker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| from re import compile | ||
| from pathlib import Path | ||
| from rq import Queue, Worker | ||
| from rq.job import Job | ||
| from podman import PodmanClient | ||
| from shutil import rmtree | ||
|
|
||
| from asu.config import settings | ||
| from asu.util import log, get_podman | ||
|
|
||
| REQUEST_HASH_LENGTH = 64 | ||
| store: Path = settings.public_path / "store" | ||
| podman: PodmanClient = get_podman() | ||
|
|
||
|
|
||
| class GCWorker(Worker): | ||
| """A Worker class that does periodic garbage collection on ASU's | ||
| public store directory. We tie into the standard `Worker` maintenance | ||
| sequence, so the period is controlled by the base class. You may change | ||
| the garbage collection frequency in podman-compose.yml by adding a | ||
| `--maintenance-interval` option to the startup command as follows (the | ||
| default is 600 seconds). | ||
|
|
||
| >>> command: rqworker ... --maintenance-interval 1800 | ||
| """ | ||
|
|
||
| hash_match = compile(f"^[0-9a-f]{{{REQUEST_HASH_LENGTH}}}$") | ||
|
|
||
| def clean_store(self) -> None: | ||
| """For performance testing, the store directory was mounted on a | ||
| slow external USB hard drive. A typical timing result showed ~1000 | ||
| directories deleted per second on that test system. The synthetic | ||
| test directories were created containing 10 files in each. | ||
| File count dominated the timing, with file size being relatively | ||
| insignificant, likely due to `stat` calls being the bottleneck. | ||
| (Just for comparison, tests against store mounted on a fast SSD | ||
| were about twice as fast.) | ||
|
|
||
| >>> Cleaning /mnt/slow/public/store: deleted 5000/5000 builds | ||
| >>> Timing analysis for clean_store: 5.081s | ||
| """ | ||
|
|
||
| deleted: int = 0 | ||
| total: int = 0 | ||
| dir: Path | ||
| queue: Queue | ||
| for dir in store.glob("*"): | ||
| if not dir.is_dir() or not self.hash_match.match(dir.name): | ||
| continue | ||
| total += 1 | ||
| for queue in self.queues: | ||
| job: Job = queue.fetch_job(dir.name) | ||
| log.info(f" Found {dir.name = } {job = }") | ||
| if job is None: | ||
| rmtree(dir) | ||
| deleted += 1 | ||
|
|
||
| log.info(f"Cleaning {store}: deleted {deleted}/{total} builds") | ||
|
|
||
| def clean_podman(self) -> None: | ||
| """Reclaim space from the various podman disk entities as they are orphaned.""" | ||
| removed = podman.containers.prune() | ||
| log.info(f"Reclaimed {removed.get('SpaceReclaimed', 0):,d}B from containers") | ||
| removed = podman.images.prune() | ||
| log.info(f"Reclaimed {removed.get('SpaceReclaimed', 0):,d}B from images") | ||
| removed = podman.volumes.prune() | ||
| log.info(f"Reclaimed {removed.get('SpaceReclaimed', 0):,d}B from volumes") | ||
|
|
||
| def run_maintenance_tasks(self): | ||
| super().run_maintenance_tasks() | ||
| self.clean_store() | ||
| self.clean_podman() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change seems unrelated?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so the other contents of the init file are not deleted.