Fix circular dependency in workflow preventing container builds#183
Draft
Fix circular dependency in workflow preventing container builds#183
Conversation
Author
|
@aparcar 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: aparcar <16000931+aparcar@users.noreply.github.com>
Co-authored-by: aparcar <16000931+aparcar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] 23.05.6: missing container for ramips/mt7621
Fix circular dependency in workflow preventing container builds
Aug 23, 2025
Member
|
🤭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub Actions workflow had a circular dependency that prevented manual container builds from working correctly. The
generate_matrixjob was trying to use its own outputneeds.generate_matrix.outputs.file_hostinstead of the workflow input parameter.This caused workflow failures when trying to rebuild specific containers like
ramips-mt7621-v23.05.6, as reported in the issue where the container was missing from the registry despite the underlying ImageBuilder being available.The fix:
Changed line 147 in
.github/workflows/containers.ymlfrom:FILE_HOST=${{ needs.generate_matrix.outputs.file_host }}to:
FILE_HOST=${{ github.event.inputs.file_host }}How to rebuild missing containers:
Maintainers can now successfully rebuild missing containers by:
v23.05.6)ramips/mt7621)This will build and push the container to the registry (e.g.,
ghcr.io/openwrt/imagebuilder:ramips-mt7621-v23.05.6).Also included documentation (
REBUILD_INSTRUCTIONS.md) explaining the rebuild process for future reference.Fixes #182.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.