[openwrt-22.03] stubby: actually switch to ca-bundle and update to 0.4.3#20235
Closed
ghost wants to merge 2 commits intoopenwrt-22.03from
unknown repository
Closed
[openwrt-22.03] stubby: actually switch to ca-bundle and update to 0.4.3#20235ghost wants to merge 2 commits intoopenwrt-22.03from unknown repository
ghost wants to merge 2 commits intoopenwrt-22.03from
unknown repository
Conversation
added 2 commits
January 7, 2023 05:12
Fixes commit 11731c8. Signed-off-by: Aquila Cooper <aquila@cpr.is>
Changelog from upstream (https://github.com/getdnsapi/stubby/blob/v0.4.3/ChangeLog): * 2022-12-22: version 0.4.3 * Fix Issue getdnsapi/stubby#330 and PR getdnsapi/stubby#324: PrivateUsers=false needed in systemd stubby.service file for stubby to start. Thanks Archcan and Petr Menšík * PR getdnsapi/stubby#323: Reduce log messages when interface is offline. Thanks Russ Bubley and Andre Heider * 2022-08-19: version 0.4.2 * Fix Issue getdnsapi/stubby#320: Stubby doesn't start without "log_level" entry. Thanks Johnny S. Lee * 2022-08-19: Version 0.4.1 * Several updates to the servers in the config file: * sinodun.dnsovertls*.com servers are removed and will be decommissioned in the near future. This leaves only the getdnsapi.net server as the default. A recommendation is made that users choose additional servers from the list available. * Additional Quad9 servers added (thanks pataquets). * LDN servers removed as the service is now stopped. * Tidy up of remaining server data. * Change `comment` lines on Uncensored server data to more clearly be comments (not valid YAML) * Fix and improve descriptions of default values * getdnsapi.net DoT servers liston on port 443 now too * Fixes for parsing of quoted key values for `tls-ca-file`, `tls-curves-list` and `resolvconf` * Add Dockerfile into `contrib` - thanks to pataquets. * Strengthen version checking for LibIDN2 during the cmake step so LibIDN2 version 2.3.3 can be properly found (thanks jpbion). * Updated stubby.service file. Thanks Bruno Pagani * log level configurable in config file with log_level setting Command line setting (with -v or -l) overrules the config file setting Signed-off-by: Aquila Cooper <aquila@cpr.is>
Contributor
|
Regarding the dependency change:
As discussed in the PR #10745 about that commit, the "ca-certs" is meant as a flexible alternative that enables the user to use either ca-certificates or ca-bundle, as some other package might explicitly require one of them and you shouldn't be forced to install both if not necessary. So, stubby accepts either of them. The flexibility is provided by openwrt/openwrt@dd29980 You proposal would force to use ca-bundle. NAK from me regarding that aspect. |
Author
|
Ah, my bad, then. I was unaware of that discussion. I'll close this PR and create another one to only update stubby. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes commit 11731c8.
Also updates stubby to 0.4.3. See the changelog from upstream for more details about the update.