Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions app/components/mcp_configurations/server_url_component.html.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<%#-- copyright
OpenProject is an open source project management software.
Copyright (C) the OpenProject GmbH

This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License version 3.

OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
Copyright (C) 2006-2013 Jean-Philippe Lang
Copyright (C) 2010-2013 the ChiliProject Team

This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License
as published by the Free Software Foundation; either version 2
of the License, or (at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

See COPYRIGHT and LICENSE files for more details.

++#%>

<%=
render(Primer::OpenProject::InputGroup.new(input_width: :large)) do |input_group|
input_group.with_text_input(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ maybe you can quickly tell me: Why is it not needed to give the text input itself a readonly? I see it is used in the form with html_content, and not as `text_field', but if only looking at code I would have expected the input is active, but simply not attached to the form semantically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I asked this myself. I copied this code from our storage forms, specifically the redirect_url over there. I'd also have expected from the code, that it's editable. But it isn't. I didn't dig deeper and just accepted that copy&paste worked and gave me the behaviour I wanted.

🙈 🙈 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

name: :server_url,
label: t(".label"),
visually_hide_label: false,
value: server_url
)

input_group.with_trailing_action_clipboard_copy_button(
value: server_url,
aria: {
label: I18n.t("button_copy_to_clipboard")
}
)

input_group.with_caption do
t(".caption")
end
end
%>
39 changes: 39 additions & 0 deletions app/components/mcp_configurations/server_url_component.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# frozen_string_literal: true

#-- copyright
# OpenProject is an open source project management software.
# Copyright (C) the OpenProject GmbH
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License version 3.
#
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
# Copyright (C) 2006-2013 Jean-Philippe Lang
# Copyright (C) 2010-2013 the ChiliProject Team
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
#
# See COPYRIGHT and LICENSE files for more details.
#++

module McpConfigurations
class ServerUrlComponent < ApplicationComponent
include OpPrimer::ComponentHelpers

def server_url
url_helpers.api_mcp_url
end
end
end
4 changes: 4 additions & 0 deletions app/forms/mcp_configurations/server_form.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ class ServerForm < ApplicationForm
)

if server_enabled?
f.html_content do
render(McpConfigurations::ServerUrlComponent.new)
end

f.text_field(
name: :title,
label: McpConfiguration.human_attribute_name(:title),
Expand Down
5 changes: 5 additions & 0 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,11 @@ en:
confirmation_live_message_checked: "The button to proceed is now active."
confirmation_live_message_unchecked: "The button to proceed is now inactive. You need to tick the checkbox to continue."

mcp_configurations:
server_url_component:
caption: "The URL at which the OpenProject MCP server will be reachable. Required for setting up MCP clients."
label: "Server URL"

op_dry_validation:
or: "or"
errors:
Expand Down
Loading