Fix MFD related crashes caused by checklists not fully loading#1371
Draft
lassombra wants to merge 2 commits intoorbiternassp:Orbiter2016from
Draft
Fix MFD related crashes caused by checklists not fully loading#1371lassombra wants to merge 2 commits intoorbiternassp:Orbiter2016from
lassombra wants to merge 2 commits intoorbiternassp:Orbiter2016from
Conversation
Fix the MFD to not cause a crash with a bad checklist file. This is an incomplete fix for crashing as it's still possible to crash if there is something wrong with the checklist state in the scenario. More work is needed.
Collaborator
|
While this might make it harder to see immediately that a checklist is an issue, it will prevent CTD for releases. |
Contributor
Author
|
I think I'm going to put this to draft and add two things:
This will improve behavior for users, but give Folger's the quick crash behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not the cleanest approach but is the most surgical change I could find to fix this bug. It ensures that even if no checklists are loaded, the checklist MFD doesn't loop until
TopStepoverflows and goes negative causing an access violation sinceTopStepis an index.