fix scroll issue with checkbox plugin when query has content #888
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a scroll issue with checkbox_options plugin.
Steps to reproduce the issue:
1 - have a multi-select with checkbox_options plugin enabled with enough options that it is still scrollable with something typed in the search box.
2 - open the select, type a query with partial match that matches enough options to allow scrolling.
3 - scroll to bottom of the list
4 - mark 2 checkboxes
problem:
after selecting the second option the list scrolls to the top making it cumbersome to select near options.
expected behaviour (fixed with this PR):
Checkbox to be marked and selection to stay visible so we can continue selecting further records.