Skip to content

feat(deployment): Add 'imagePullSecrets' to deployment #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(deployment): Add 'imagePullSecrets' to deployment #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98fa979
feat(deployment): Add 'imagePullSecrets' to deployment
Aug 13, 2024
af17000
Update README.md
Mart-Kuc Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/k8s-gateway/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ The following table lists the configurable parameters of the k8s_gateway chart a
| `image.repository` | Image repository | `oriedge/k8s_gateway` |
| `image.tag` | Image tag | `latest` |
| `image.pullPolicy` | Image pull policy | `Always` |
| `image.imagePullSecrets` | Image registry secret names | `[]` |
| `nodeSelector` | Node labels for pod assignment | `{}` |
| `tolerations` | Use to schedule on node taint to be not schedulable | `[]` |
| `topologySpreadConstraints` | Use topology spread constraints to control how Pods are spread across your cluster | `[]` |
Expand Down
4 changes: 4 additions & 0 deletions charts/k8s-gateway/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ spec:
checksum/config: {{ toYaml .Values | sha256sum }}
spec:
serviceAccountName: {{ include "k8s-gateway.serviceAccountName" . }}
{{- with .Values.image.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:
- name: {{ .Chart.Name }}
image: "{{- if .Values.image.registry }}{{ .Values.image.registry }}/{{- end }}{{ .Values.image.repository }}:{{ .Values.image.tag }}"
Expand Down
1 change: 1 addition & 0 deletions charts/k8s-gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ image:
repository: oriedge/k8s_gateway
tag: v0.4.0
pullPolicy: IfNotPresent
imagePullSecrets: []

# Delegated domain
domain: ""
Expand Down