Skip to content

Conversation

@MatthijsBurgh
Copy link
Collaborator

No description provided.

This comment was marked as outdated.

@MatthijsBurgh MatthijsBurgh requested a review from Copilot July 24, 2025 09:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds vector-based versions of the JntToCart method for both forward kinematics position and velocity solvers in PyKDL. The changes enable computing forward kinematics for all segments in a kinematic chain simultaneously, returning results in a list format rather than computing individual segments one at a time.

Key changes:

  • Implements vector versions of JntToCart methods using lambda functions with pybind11
  • Adds comprehensive test coverage for both position and velocity vector forward kinematics
  • Replaces previously commented-out implementations with working solutions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
python_orocos_kdl/PyKDL/kinfam.cpp Implements vector versions of JntToCart methods for ChainFkSolverPos and ChainFkSolverVel using lambda wrappers
python_orocos_kdl/tests/kinfamtest.py Adds test methods testFkPosVect and testFkVelVect to validate the new vector functionality

@MatthijsBurgh MatthijsBurgh merged commit 94e9ea4 into master Aug 5, 2025
59 of 60 checks passed
@MatthijsBurgh MatthijsBurgh deleted the feature/container_args branch August 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants