docs: nginx rewrite conflict with RedirectAdminMiddleware#1940
Open
Laplace-Transformer wants to merge 1 commit intoory:masterfrom
Open
docs: nginx rewrite conflict with RedirectAdminMiddleware#1940Laplace-Transformer wants to merge 1 commit intoory:masterfrom
Laplace-Transformer wants to merge 1 commit intoory:masterfrom
Conversation
Removed removal of nginx rewrite. Conflicted with "RedirectAdminMiddleware" in the kratos code, which adds the prefix "admin/" if not present.
Member
|
To merge this we would probably need to run through this example step by step, unless there is a clear reason why this was in there for so long and noone ever noticed it / complained about it? |
Author
|
Hi again. I don't think many people use this documentation. I've tried to follow it but I've had few hiccups on the way that I'm currently trying to correct. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed removal of nginx rewrite. Conflicted with "RedirectAdminMiddleware" in the kratos code, which adds the prefix "admin/" if not present.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
Further comments