fix: allow show_verification_ui for flows.settings.after.profile.hooks#4481
Open
camero2734 wants to merge 1 commit intoory:masterfrom
Open
fix: allow show_verification_ui for flows.settings.after.profile.hooks#4481camero2734 wants to merge 1 commit intoory:masterfrom
camero2734 wants to merge 1 commit intoory:masterfrom
Conversation
314d97a to
00a7418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #4402 was merged, there is no way to get the verification UI to show after the user changes their email.
It seems this was intended, as it's even documented here:
https://www.ory.com/docs/actions/require-verified-address#show-verification-screen-after-address-change
But if you actually configure this (when self-hosting), you get an error that that hook isn't allowed there (I got this both in the officially released
oryd/kratos:v1.3.1image, as well as in a custom build based off of themasterbranch)I regenerated the schema via
./script/render-schemas.sh. After this change, the following is now allowed as expected:Related issue(s)
#4402
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.