fix: set NoStartTLS when disable_startttls=true#4516
Open
Flgado wants to merge 2 commits intoory:masterfrom
Open
fix: set NoStartTLS when disable_startttls=true#4516Flgado wants to merge 2 commits intoory:masterfrom
Flgado wants to merge 2 commits intoory:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users configuring SMTP with
disable_starttls=trueto force plaintext connections (common in development environments) experience connection failures with "unencrypted connection" errors, despite explicitly disabling StartTLS.Root Cause
In smtp.go, when
disable_starttls=trueis set, the code correctly skips settingMandatoryStartTLSbut fails to explicitly setNoStartTLS. This leaves the dialer with the defaultOpportunisticStartTLSpolicy, which still attempts TLS connections when the SMTP server advertises STARTTLS capability.This can be confuse for users, because they explicite set the disable_starttls to true.
Solution
Explicitly set
StartTLSPolicy = gomail.NoStartTLSwhen `disable_starttls=true to completely disable TLS negotiation attempts.Related issue(s)
#4498
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments