Skip to content

Conversation

@kalikiana
Copy link
Member

None of the other properties are required and the group is identified by its ID when updating an existing job group.

None of the other properties are required and the group is identified
by its ID when updating an existing job group.
@Martchus
Copy link
Contributor

Martchus commented Nov 6, 2025

Looks generally good. Can you start the commit message with a verb in imperative following our usual style?

@kalikiana
Copy link
Member Author

Note I need to investigate the unit tests, but since this is ad-hoc work I am not prioritizing it right now:

    #   Failed test '400 Bad Request'                                                               
    #   at t/api/10-jobgroups.t line 450.                                                           
    #          got: '200'                                                                           
    #     expected: '400'                                                                           
                                                                                                    
    #   Failed test 'Unable to update parent group with empty or blank name'                        
    #   at t/api/10-jobgroups.t line 450.                                                           
    #          got: undef                                                                           
    #     expected: 'Erroneous parameters (name missing)'                                           
                                                                                                    
    #   Failed test '400 Bad Request'                                                               
    #   at t/api/10-jobgroups.t line 454.                                                           
    #          got: '200'                                                                           
    #     expected: '400'                                                                           
                                                                                                    
    #   Failed test 'Unable to update job group with empty or blank name'                           
    #   at t/api/10-jobgroups.t line 454.                                                           
    #          got: undef                                                                           
    #     expected: 'Erroneous parameters (name missing)'                                           
    # Looks like you failed 4 tests of 12.                                                          
                                                                                                    
#   Failed test 'prevent update parent/job group with empty or blank name'                          
#   at t/api/10-jobgroups.t line 459.                                                               
# Looks like you failed 1 test of 13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants