-
Notifications
You must be signed in to change notification settings - Fork 220
Document how to schedule tests via @openqa: in a GHA #6834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
d535e46 to
702c1ef
Compare
Martchus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make more sense to keep detailed documentation about scripts from https://github.com/os-autoinst/os-autoinst-scripts in that repository.
| ---- | ||
| name: Schedule openQA tests mentioned via @openqa: | ||
| on: | ||
| pull_request_target: | ||
| workflow_dispatch: | ||
| env: | ||
| OPENQA_HOST: ${{ secrets.OPENQA_URL }} | ||
| OPENQA_API_KEY: ${{ secrets.OPENQA_API_KEY }} | ||
| OPENQA_API_SECRET: ${{ secrets.OPENQA_API_SECRET }} | ||
| GH_REPO: ${{ github.event.pull_request.head.repo.full_name }} | ||
| GH_REF: ${{ github.event.pull_request.head.ref }} | ||
| GH_PR_BODY: ${{ github.event.pull_request.body }} | ||
| jobs: | ||
| clone_and_monitor_job_from_pr: | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: registry.opensuse.org/devel/openqa/containers/tumbleweed:client | ||
| steps: | ||
| - uses: os-autoinst/os-autoinst-scripts/actions/clone-job@master | ||
| ---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really add a copy of this here? Isn't it enough if we just refer to the documentation within the script itself? With your change we'll have to keep both places in-sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script itself contains examples if you mean that. I don't find that very discoverable or accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we are referring to it explicitly making it discoverable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs from os-autoinst-scripts don't end up on open.qa/docs...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs from os-autoinst-scripts don't end up on open.qa/docs...
That's true but if one follows the link to a nicely rendered markdown README from os-autoinst-scripts that should suffice
And mention that comments require API access. See: https://progress.opensuse.org/issues/191635
702c1ef to
754c751
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6834 +/- ##
=======================================
Coverage 99.25% 99.26%
=======================================
Files 402 402
Lines 41396 41396
=======================================
+ Hits 41089 41090 +1
+ Misses 307 306 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
okurz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And mention that comments require API access.
See: https://progress.opensuse.org/issues/191635