Skip to content

Conversation

@kalikiana
Copy link
Member

And mention that comments require API access.

See: https://progress.opensuse.org/issues/191635

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Great PR! Please pay attention to the following items before merging:

Files matching docs/*.asciidoc:

This is an automatically generated QA checklist based on modified files.

@kalikiana
Copy link
Member Author

@kalikiana kalikiana force-pushed the docs_gha_openqa branch 2 times, most recently from d535e46 to 702c1ef Compare November 6, 2025 14:29
@kalikiana kalikiana marked this pull request as ready for review November 6, 2025 14:30
Copy link
Contributor

@Martchus Martchus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make more sense to keep detailed documentation about scripts from https://github.com/os-autoinst/os-autoinst-scripts in that repository.

Comment on lines +2335 to +2354
----
name: Schedule openQA tests mentioned via @openqa:
on:
pull_request_target:
workflow_dispatch:
env:
OPENQA_HOST: ${{ secrets.OPENQA_URL }}
OPENQA_API_KEY: ${{ secrets.OPENQA_API_KEY }}
OPENQA_API_SECRET: ${{ secrets.OPENQA_API_SECRET }}
GH_REPO: ${{ github.event.pull_request.head.repo.full_name }}
GH_REF: ${{ github.event.pull_request.head.ref }}
GH_PR_BODY: ${{ github.event.pull_request.body }}
jobs:
clone_and_monitor_job_from_pr:
runs-on: ubuntu-latest
container:
image: registry.opensuse.org/devel/openqa/containers/tumbleweed:client
steps:
- uses: os-autoinst/os-autoinst-scripts/actions/clone-job@master
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really add a copy of this here? Isn't it enough if we just refer to the documentation within the script itself? With your change we'll have to keep both places in-sync.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script itself contains examples if you mean that. I don't find that very discoverable or accessible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we are referring to it explicitly making it discoverable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs from os-autoinst-scripts don't end up on open.qa/docs...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs from os-autoinst-scripts don't end up on open.qa/docs...

That's true but if one follows the link to a nicely rendered markdown README from os-autoinst-scripts that should suffice

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.26%. Comparing base (6bd1da8) to head (754c751).
⚠️ Report is 51 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6834   +/-   ##
=======================================
  Coverage   99.25%   99.26%           
=======================================
  Files         402      402           
  Lines       41396    41396           
=======================================
+ Hits        41089    41090    +1     
+ Misses        307      306    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants