Skip to content

Conversation

@rbmarliere
Copy link
Contributor

@rbmarliere rbmarliere commented Nov 26, 2025

In the case where a subtest don't have proper KTAP output, nothing will be shown in the UI. This is not ideal since it forces the user to open the individual log asset file and also prevent them from easily opening bugs from the helper buttons.

VR: https://rmarliere-openqa.qe.prg2.suse.org/tests/1635

@rbmarliere rbmarliere force-pushed the ktap_unparsed_default branch 2 times, most recently from e5c6451 to 16cfe09 Compare November 26, 2025 23:06
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.26%. Comparing base (131df4d) to head (7b3f46b).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6855      +/-   ##
==========================================
- Coverage   99.26%   99.26%   -0.01%     
==========================================
  Files         402      402              
  Lines       41522    41530       +8     
==========================================
+ Hits        41218    41225       +7     
- Misses        304      305       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@pevik pevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks!

@rbmarliere rbmarliere force-pushed the ktap_unparsed_default branch from 16cfe09 to 33a61f3 Compare November 27, 2025 11:01
@rbmarliere
Copy link
Contributor Author

Thank you @perlpunk and @Martchus . I would just like to wait for @schlad now :)

Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for further review as you mentioned

Copy link
Contributor

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the case where a subtest don't have proper KTAP output, nothing will be
shown in the UI. This is not ideal since it forces the user to open the
individual log asset file and also prevent them from easily opening bugs
from the helper buttons.
@rbmarliere rbmarliere force-pushed the ktap_unparsed_default branch from 33a61f3 to 7b3f46b Compare November 27, 2025 11:07
@rbmarliere
Copy link
Contributor Author

rbmarliere commented Nov 27, 2025

Thanks @okurz . FWIW Last update was just a small fix to the commit message.

@schlad
Copy link
Contributor

schlad commented Nov 28, 2025

this makes sense!
+1 from my end.
IMHO - ready to get merged

@mergify mergify bot merged commit a1f2799 into os-autoinst:master Nov 28, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants