-
Notifications
You must be signed in to change notification settings - Fork 220
parser: ktap: Show full output by default if no line was parsed #6855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e5c6451 to
16cfe09
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
- Coverage 99.26% 99.26% -0.01%
==========================================
Files 402 402
Lines 41522 41530 +8
==========================================
+ Hits 41218 41225 +7
- Misses 304 305 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pevik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement, thanks!
16cfe09 to
33a61f3
Compare
okurz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for further review as you mentioned
perlpunk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the case where a subtest don't have proper KTAP output, nothing will be shown in the UI. This is not ideal since it forces the user to open the individual log asset file and also prevent them from easily opening bugs from the helper buttons.
33a61f3 to
7b3f46b
Compare
|
Thanks @okurz . FWIW Last update was just a small fix to the commit message. |
|
this makes sense! |
In the case where a subtest don't have proper KTAP output, nothing will be shown in the UI. This is not ideal since it forces the user to open the individual log asset file and also prevent them from easily opening bugs from the helper buttons.
VR: https://rmarliere-openqa.qe.prg2.suse.org/tests/1635