Prevent override the autoinst-log context within handle_unreachable #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3flex
force-pushed
the
label_known_issues_override
branch
3 times, most recently
from
43c7ebc to
348e95e
Compare
d3flex
force-pushed
the
label_known_issues_override
branch
from
348e95e to
a3539b4
Compare
d3flex
force-pushed
the
label_known_issues_override
branch
2 times, most recently
from
a05283a to
3ddb915
Compare
perlpunk
reviewed
Nov 13, 2024
d3flex
force-pushed
the
label_known_issues_override
branch
from
3ddb915 to
fcecd1c
Compare
perlpunk
reviewed
Nov 13, 2024
perlpunk
reviewed
Nov 13, 2024
perlpunk
reviewed
Nov 13, 2024
d3flex
force-pushed
the
label_known_issues_override
branch
from
fcecd1c to
b2a8159
Compare
d3flex
force-pushed
the
label_known_issues_override
branch
from
b2a8159 to
af67a70
Compare
perlpunk
reviewed
Nov 14, 2024
d3flex
force-pushed
the
label_known_issues_override
branch
from
af67a70 to
73aed5c
Compare
perlpunk
reviewed
Nov 15, 2024
perlpunk
reviewed
Nov 15, 2024
d3flex
force-pushed
the
label_known_issues_override
branch
from
73aed5c to
6ac7a1f
Compare
Martchus
requested changes
Nov 25, 2024
d3flex
force-pushed
the
label_known_issues_override
branch
2 times, most recently
from
d872396 to
0f59bc3
Compare
perlpunk
reviewed
Nov 26, 2024
perlpunk
force-pushed
the
label_known_issues_override
branch
from
b113b67 to
38ba8dc
Compare
|
I pushed a commit. |
perlpunk
previously requested changes
Nov 26, 2024
perlpunk
reviewed
Nov 26, 2024
d3flex
force-pushed
the
label_known_issues_override
branch
4 times, most recently
from
6dd1177 to
f5bcce6
Compare
perlpunk
reviewed
Nov 27, 2024
perlpunk
reviewed
Nov 27, 2024
`handle_unreachable` can override the log file passed to the function. This should not allowed because when the `handle_unreviewed` function is reach will run with incorrect logs. Solving the issue creating a separate temp local file for handle_unreachable and extract timeago in a variable in order to use it to determine the age of the job. This keeps clear now the out variable which should only contain the autoinst-log+reason. https://progress.opensuse.org/issues/166772 Signed-off-by: ybonatakis <[email protected]> Signed-off-by: Ioannis Bonatakis <[email protected]>
Fix exit handler
perlpunk
force-pushed
the
label_known_issues_override
branch
from
f5bcce6 to
47056a1
Compare
/home/runner/work/scripts/scripts/.bpan/.bpan/lib/test-tap.bash: ERROR: line 168 Tests pass, it's just printing that error. I'm not sure why that's needed here as `try` should take care of it, but I think it's because the error for calling investigate_issue without an argument is "Unbound variable" and that might not be catched the same way as other error messages. I might ask the test-tap author about it.
okurz
approved these changes
Nov 27, 2024
and move creation of temp files to top level (this only needs to be done once)
Martchus
approved these changes
Nov 27, 2024
and pass the correct variable. investigate_issue gets a url as a parameter and then strips everything until the last slash to get the id.
Apparently it wasn't too broken for the test to fail though
perlpunk
force-pushed
the
label_known_issues_override
branch
from
02626cd to
eabd76b
Compare
|
I added some more fixes myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle_unreachablecan override the log file passed to the function. This should not allowed because when thehandle_unreviewedfunction is reach will run with incorrect logs. Solving the issue creating a separate temp local filefor handle_unreachable and extract timeago in a variable in order to use it to
determine the age of the job. This keeps clear now the out variable which
should only contain the autoinst-log+reason.
https://progress.opensuse.org/issues/166772