-
Notifications
You must be signed in to change notification settings - Fork 23
Tweak some docstrings #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak some docstrings #1286
Conversation
b088fff to
7ae39d2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1286 +/- ##
=======================================
Coverage 76.51% 76.51%
=======================================
Files 61 61
Lines 4910 4910
=======================================
Hits 3757 3757
Misses 1153 1153
🚀 New features to boost your workflow:
|
7ae39d2 to
86463fe
Compare
|
The "Test GAP packages distro" failures (were tests just hang and are cancelled after 20 minutes) are puzzling, but don't seem to be related to this patch: they also occur on master. And it is always the same 11 packages, so not purely random. But I can't really spot a pattern in that list of packages ?!?
Looking at the CI history logs, it seems that this started between November 14 (last "good" build) and November 17 (first "bad" build). What could have changed in that time, though? The various Any ideas, @lgoettgens @ThomasBreuer ? |
|
Argh wait, now it works on this PR after restarting it one more time??? That's a weird coincidence (but I'll take it) |
My best guess is that this was some weird interaction of the cloudflare issues last week, together with some caching in github actions. |
src/setup.jl
Outdated
| - two TOML files, `Manifest.toml` and `Project.toml`, which are required by | ||
| `gap.sh` to function (they record the precise versions of GAP.jl and other | ||
| Julia packages involved) | ||
| create_gap_sh(dstdir::String; use_active_project::Bool=false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kwarg was not part of the public API until this PR. I just wanted to mention it, so that it can be a conscious decision. No objection from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this part then so we can discuss it another time. Also it would conflict with PR #1300
Partially inspired by https://github.com/tecosaur/CheckDoc.jl feedback.
86463fe to
eae1036
Compare
Partially inspired by https://github.com/tecosaur/CheckDoc.jl feedback.