CWE-460 #962
CWE-460 #962
Conversation
Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
kets99
changed the title
Signed-off-by: Ketki <[email protected]>
kets99
changed the title
|
|
||
| # CWE-460: Improper Cleanup on Thrown Exception | ||
|
|
||
| The product does not clean up its state or incorrectly cleans up its state when an exception is thrown, leading to unexpected state or control flow. |
There was a problem hiding this comment.
We usually make the first sentence something like:
Ensure that your code fully and correctly cleans up its state whenever an exception occurs to avoid unexpected state or control flow.
Rather than taking the actual CWE description. We have plans to change the naming of the rulesets in the future in order to avoid this confusion, but for now, I'd change the first sentence to be "always do this" or "never do this"
docs/Secure-Coding-Guide-for-Python/CWE-664/CWE-460/noncompliant.py
Outdated
Show resolved
Hide resolved
|
hi @BartKaras1128 thank you so much for the feedback! i will keep it in mind when submitting other PRs! =) |
…nt.py Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Co-authored-by: Bartlomiej Karas <[email protected]> Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
|
Hi @kets99! Thanks for the PR and sorry for missing to kick-off the linter (which does not run automatically for new contributors). It found some minor syntax issues. Can you address them? You'll find the log here: https://github.com/ossf/wg-best-practices-os-developers/actions/runs/16997777562/job/48808825760?pr=962 If you need any support, please let me know! |
Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
Signed-off-by: Ketki <[email protected]>
No description provided.