Skip to content

Conversation

myteron
Copy link
Contributor

@myteron myteron commented Sep 4, 2025

460 was missing on main readme.md for pySCG

Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: Helge Wehder <[email protected]>
@myteron myteron changed the title adding 460 to main table adding 460 to main table, fixing cosmetics and formatting Sep 4, 2025
Signed-off-by: Helge Wehder <[email protected]>
@myteron
Copy link
Contributor Author

myteron commented Sep 4, 2025

Hi @kets99 , thank you very much for the contribution, very much appreciated !

I have applied some cosmetics such as back ticks to the code and README.md. We have example code typically during the introduction so I moved it up.
Code file names following a specific format that I applied for the file names and within the README.md.
I made sure the README.md is matching the code in the files as I assume the files where more correct?
Added a reference I know about to the reference table.

Please check and let me know if I broke anything in terms of phrasing or coding.

Thanks

@s19110
Copy link
Contributor

s19110 commented Sep 16, 2025

reviewing

Copy link
Contributor

@s19110 s19110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left small cosmetic suggestions.

Copy link
Contributor

@BartKaras1128 BartKaras1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@myteron myteron merged commit ca10c61 into ossf:main Sep 18, 2025
2 checks passed
s19110 added a commit to s19110/wg-best-practices-os-developers that referenced this pull request Sep 18, 2025
* adding 460 to main table
* some more cosmetics on readme, created example01.py code and moved it up, fix file naming
* also added comment changes to the complian01.py code

---------

Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: myteron <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]>
sueszli pushed a commit to sueszli/wg-best-practices-os-developers that referenced this pull request Sep 29, 2025
* adding 460 to main table
* some more cosmetics on readme, created example01.py code and moved it up, fix file naming
* also added comment changes to the complian01.py code

---------

Signed-off-by: Helge Wehder <[email protected]>
Signed-off-by: myteron <[email protected]>
Co-authored-by: Hubert Daniszewski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants