Skip to content

AO3-7210 I18n skins-creating.html help file#5554

Merged
Bilka2 merged 9 commits intootwcode:masterfrom
hunternet93:AO3_7210_migrate_skins_creating_help
Feb 10, 2026
Merged

AO3-7210 I18n skins-creating.html help file#5554
Bilka2 merged 9 commits intootwcode:masterfrom
hunternet93:AO3_7210_migrate_skins_creating_help

Conversation

@hunternet93
Copy link
Contributor

Issue

https://otwarchive.atlassian.net/browse/AO3-7210

Purpose

Migrates the static skins-creating.html help file to a localized view on the help controller.

@hunternet93
Copy link
Contributor Author

Styling: When in a modal, the skins-creating page is in a context where rules like .userstuff dt apply, causing <dt> headers to appear in bold. However, when rendered directly at /help/skins_creating, the parent userstuff class is not applied, resulting in the page being a bit harder to read. Should this be fixed by applying .userstuff as a class on a parent element, or in some other way?

@slavalamp
Copy link
Contributor

Styling: When in a modal, the skins-creating page is in a context where rules like .userstuff dt apply, causing <dt> headers to appear in bold. However, when rendered directly at /help/skins_creating, the parent userstuff class is not applied, resulting in the page being a bit harder to read. Should this be fixed by applying .userstuff as a class on a parent element, or in some other way?

that's a problem with all new help pages (and not the only problem either), i think the ad&t are still deciding what to do about it, so you don't need to do anything right now. i'm expecting there will be a new issue or several in the future for this

@hunternet93 hunternet93 marked this pull request as ready for review January 21, 2026 21:20
@Bilka2 Bilka2 changed the title AO3-7210: Migrate skins-creating.html help file to help controller AO3-7210 Migrate skins-creating.html help file to help controller Jan 22, 2026
@Bilka2 Bilka2 self-requested a review January 22, 2026 21:39
Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this complicated file!

@Bilka2 Bilka2 changed the title AO3-7210 Migrate skins-creating.html help file to help controller AO3-7210 I18n skins-creating.html help file Jan 27, 2026
Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more things!

Copy link
Contributor

@Bilka2 Bilka2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much (also for fixing the merge conflict)!

@Bilka2
Copy link
Contributor

Bilka2 commented Feb 10, 2026

credit note based on old prs: Hunter Ada Smith (she/her)

@Bilka2 Bilka2 merged commit 4260538 into otwcode:master Feb 10, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants