AO3-7030 Only allow official users to apply to make skins public#5571
Open
sarken wants to merge 31 commits intootwcode:masterfrom
Open
AO3-7030 Only allow official users to apply to make skins public#5571sarken wants to merge 31 commits intootwcode:masterfrom
sarken wants to merge 31 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7030
Purpose
Prevents users who don't have the "official" role from applying to make skins public. (It is probably helpful to know that the
publicattribute doesn't make a skin public -- it just applies to make the skin public.)It also adds a task for clearing out any skins that are currently in the approval queue or that have been rejected.
In the specs, I've left a few comments about the redirects not matching reality, e.g.
# This actually redirects to the logged in user's dashboard.Basically what happens is the tested action redirects you to the show page for the skin, but thecheck_visibilitybefore_actionfor the skin show page then redirects somewhere else. That means what the user experiences is a bit different from what the controller action says to do. It's not new behavior, just something I found a bit confusing when I was trying to write the tests. It might be worth tweaking in the future to avoid the double redirect, but maybe not.