Include shipping weight details in product data#107
Include shipping weight details in product data#107Andrew998 wants to merge 4 commits intoouteredge:masterfrom
Conversation
Added shipping weight details for Google Merchant, formatted as a string with 6 decimal places. Included condition to check for product weight before adding to data.
|
@Andrew998 Thanks for the contribution. This should respect the module config: Also, why rounding to 6 decimal places? Magneto rounds to 4 decimal places, so this seems unnecessary. |
|
Thanks. I'm not too familiar with coding for Magento so all comments are welcome. Is the process that I make those changes to the contribution? |
|
Hi Andrew, Yes please go ahead and update your merge request and we will review it again for you. If not, we can put it in our roadmap to implement at a later date. |
…y weight. Updated weight formatting to use 4 decimal places instead of 6. Update check for display weight.
Corrected comment to specify weight formatting with 4 decimal places.
|
The latest commit removes the check for a valid weight on the product. As well as checking if the config allows weight to be included, you must still check that a weight existing on the product. See the short description as an example of this logic. |
Add weight check to include shipping details for products.
|
Thank you. I'll get there eventually! |
Added shipping weight details for Google Merchant, formatted as a string with 6 decimal places. Included condition to check for product weight before adding to data.