-
Notifications
You must be signed in to change notification settings - Fork 3.4k
test-http-client-headers-array #19411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated 1:02 PM PT - Jul 25th, 2025
@cirospaciari, your commit 3123c2b is building: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is run in the server as well as the client, then we should do this in C++ and not in JS. If this is only in the client, it's fine though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this PR don't fully fixes the node.js test (because fetch limitations right now) but do significant work to improve it, would open a Issue for this to remember us to remove the Bun undefined checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete a.js, otherwise LGTM
No description provided.