Skip to content

Conversation

pfgithub
Copy link
Collaborator

@pfgithub pfgithub commented May 1, 2025

No description provided.

@robobun
Copy link
Collaborator

robobun commented May 1, 2025

Updated 1:02 PM PT - Jul 25th, 2025

@cirospaciari, your commit 3123c2b is building: #21475

@pfgithub pfgithub requested review from a team, 190n and alii and removed request for a team May 1, 2025 20:30
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is run in the server as well as the client, then we should do this in C++ and not in JS. If this is only in the client, it's fine though.

Jarred-Sumner
Jarred-Sumner previously approved these changes May 2, 2025
Copy link
Member

@cirospaciari cirospaciari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR don't fully fixes the node.js test (because fetch limitations right now) but do significant work to improve it, would open a Issue for this to remember us to remove the Bun undefined checks.

@pfgithub pfgithub requested review from 190n and removed request for alii May 6, 2025 22:52
Copy link
Contributor

@190n 190n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete a.js, otherwise LGTM

190n
190n previously approved these changes May 7, 2025
@pfgithub pfgithub requested a review from Jarred-Sumner May 15, 2025 19:38
@pfgithub pfgithub closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants