ci: Switch build-zig to use EC2 #19487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 6:18 PM PT - May 5th, 2025
✅ @Electroid, your commit c62e4e224f24a7714e5ad1ce9e99e9c6830f03d5 passed in 🧪 To try this PR locally: bunx bun-pr 19487That installs a local version of the PR into your bun-19487 --bun |
190n
reviewed
May 6, 2025
Comment on lines
+58
to
+64
| if(CI AND CMAKE_HOST_APPLE) | ||
| set(ZIG_COMPILER_SAFE_DEFAULT ON) | ||
| else() | ||
| set(ZIG_COMPILER_SAFE_DEFAULT OFF) | ||
| endif() | ||
|
|
||
| optionx(ZIG_COMPILER_SAFE BOOL "Download a ReleaseSafe build of the Zig compiler. Only availble on macos aarch64." DEFAULT ${ZIG_COMPILER_SAFE_DEFAULT}) |
Contributor
There was a problem hiding this comment.
It would be nice to get ReleaseSafe zig builds for linux x64 (it seems like we tried to here but something went wrong?). There is at least one bug in the compiler (ziglang/zig#21463) that can make it emit broken code and only crash if the compiler is built in safe mode. ReleaseSafe means we get a deterministic crash when the Zig compiler reaches undefined behavior instead of hoping that it either crashes or happens to produce the right code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?