@types/bun: Improvements to Bun.SQL #19488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alii
added
types
|
Updated 4:13 PM PT - May 6th, 2025
✅ @alii, your commit c346861e11d20433f3fa67a202a27e3a72d77072 passed in 🧪 To try this PR locally: bunx bun-pr 19488That installs a local version of the PR into your bun-19488 --bun |
cirospaciari
reviewed
May 6, 2025
Co-authored-by: Ciro Spaciari <[email protected]>
cirospaciari
previously approved these changes
May 6, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
alii
requested review from
a team,
pfgithub and
Jarred-Sumner
and removed request for
a team
cirospaciari
approved these changes
May 6, 2025
pfgithub
reviewed
May 6, 2025
pfgithub
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #18253
Some improvements to Bun.SQL types
Fixes a conflict introduced in recently-published @types/[email protected]
Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes
How did you verify your code works?
Updated sql.ts in bun-types integration test.