refactor(HttpParser.h) make it more readable #19489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 11:40 PM PT - May 8th, 2025
❌ @cirospaciari, your commit 9b97702 has 1 failures in
🧪 To try this PR locally: bunx bun-pr 19489That installs a local version of the PR into your bun-19489 --bun |
cirospaciari
force-pushed
the
ciro/http-parser-refactor
branch
from
8a01702 to
42704b3
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
cirospaciari
force-pushed
the
ciro/http-parser-refactor
branch
from
9dcf1ae to
0989896
Compare
cirospaciari
changed the title
190n
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Minimal changes to HTTPParser.h to make it easier to read and understand
How did you verify your code works?
CI