-
Notifications
You must be signed in to change notification settings - Fork 3.5k
test-abortcontroller.js #19492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test-abortcontroller.js #19492
Conversation
|
Updated 7:03 PM PT - Jun 30th, 2025
❌ @pfgithub, your commit 42596f2 has 2 failures in
🧪 To try this PR locally: bunx bun-pr 19492That installs a local version of the PR into your bun-19492 --bun |
src/bun.js/bindings/JSValue.zig
Outdated
| pub fn getClassName(this: JSValue, global: *JSGlobalObject, ret: *ZigString) void { | ||
| pub fn getClassName(this: JSValue, global: *JSGlobalObject, ret: *ZigString) bun.JSError!void { | ||
| var scope: bun.JSC.CatchScope = undefined; | ||
| scope.init(global, @src(), .assertions_only); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this should be .enabled otherwise it will never think there is an exception. .assertions_only is for when you have a way other than the CatchScope to tell if an exception was thrown (like a return value) and you only need the CatchScope because it will call exception().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fromJSHostCallGeneric uses .assertions_only itself so it might be wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, i hadn't seen that function, yeah it is wrong
/// You have another way to detect exceptions and are only using the CatchScope to prove that
/// exceptions are checked.
///
/// This CatchScope will only do anything when assertions are enabled. Otherwise, init and
/// deinit do nothing and it always reports there is no exception.
assertions_only,
64a2d70 to
2161bab
Compare
…s.cpp), do they not test WebCore with exception checker?
cdca597 to
2b40119
Compare
Waiting on #20494