Fixes #19475 #19495
Merged
Fixes #19475 #19495
+112
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Updated 2:38 PM PT - May 6th, 2025
✅ @dylan-conway, your commit a52f2fd2df40179f898e43a06daf0b2c9d362829 passed in 🧪 To try this PR locally: bunx bun-pr 19495That installs a local version of the PR into your bun-19495 --bun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #19475. The underlying bug: a reference to a stale ASTMemoryAllocator. This caused issues when a frontend bundle in the dev server has an in-flight build and the main thread hot reloads a file in the backend code.
Also fixes an assertion failure on Linux when the file watcher has a large number of events in a release build (where its fast enough to occur).
How did you verify your code works?
The non-automated stress test no longer asserts