Implement test-tls-connect-timeout-option.js #19503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
cirospaciari
reviewed
May 6, 2025
src/js/node/net.ts
Outdated
| } | ||
| this._handle?.timeout(Math.ceil(timeout / 1000)); | ||
| this.timeout = timeout; | ||
| this._timeout = timeout; |
There was a problem hiding this comment.
Actually this is wrong should be this.timeout because nodejs will do this.timeout = msecs; in setStreamTimeout https://github.com/nodejs/node/blob/main/lib/internal/stream_base_commons.js#L236-L243
|
Converting to draft for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How did you verify your code works?
Test added and passes. Some of this feels like a bandaid so would be useful to get some insights about potentially better ways to implement this.