Skip to content

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented May 7, 2025

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@robobun
Copy link
Collaborator

robobun commented May 7, 2025

Updated 4:45 PM PT - May 9th, 2025

@cirospaciari, your commit d9268fe4d02f26ce8b7217aa121485a24c500d84 passed in Build #16413! 🎉


🧪   To try this PR locally:

bunx bun-pr 19527

That installs a local version of the PR into your bun-19527 executable, so you can run:

bun-19527 --bun

@cirospaciari cirospaciari changed the base branch from main to ciro/http-parser-refactor May 7, 2025 20:09
@cirospaciari cirospaciari requested review from alii and a team and removed request for a team May 9, 2025 11:58
@cirospaciari cirospaciari requested review from dylan-conway and 190n May 9, 2025 12:51
@cirospaciari cirospaciari requested a review from dylan-conway May 9, 2025 19:30
@cirospaciari cirospaciari requested a review from 190n May 9, 2025 21:31
Copy link
Contributor

@190n 190n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more comments on node-http.test.ts, and then let's see what happens with test-http-server-keepalive-req-gc.js in CI

@cirospaciari cirospaciari requested a review from 190n May 9, 2025 22:31
@Jarred-Sumner Jarred-Sumner merged commit 0a0205b into main May 11, 2025
60 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/http-parser-errors branch May 11, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants