Skip to content

fix sql.test.ts #19544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

fix sql.test.ts #19544

merged 2 commits into from
May 9, 2025

Conversation

190n
Copy link
Contributor

@190n 190n commented May 9, 2025

What does this PR do?

  • removes tests that failed due to changed postgres implementation details
  • pins the postgres version so this doesn't happen again

How did you verify your code works?

CI

@190n 190n requested a review from cirospaciari May 9, 2025 00:53
@robobun
Copy link
Collaborator

robobun commented May 9, 2025 •
edited
Loading

Updated 6:42 PM PT - May 8th, 2025

✅ @190n, your commit d9a6a23178fff1e08fd764a63085881cd949f794 passed in Build #16324! 🎉

🧪   To try this PR locally:

bunx bun-pr 19544

That installs a local version of the PR into your bun-19544 executable, so you can run:

bun-19544 --bun

@oven-sh oven-sh deleted a comment May 9, 2025
@Jarred-Sumner Jarred-Sumner merged commit 71c770f into main May 9, 2025
62 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ben/sql-test branch May 9, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cirospaciari cirospaciari cirospaciari approved these changes

@alii alii alii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@190n @robobun @cirospaciari @alii @Jarred-Sumner