Fix unusual LogHandler crash on shutdown#1735
Open
ada-tv wants to merge 1 commit intooverte-org:masterfrom
Open
Fix unusual LogHandler crash on shutdown#1735ada-tv wants to merge 1 commit intooverte-org:masterfrom
ada-tv wants to merge 1 commit intooverte-org:masterfrom
Conversation
ada-tv
added
bug
ksuprynowicz
approved these changes
Aug 17, 2025
Member
ksuprynowicz
left a comment
ksuprynowicz
left a comment
There was a problem hiding this comment.
Everything looks good :)
ksuprynowicz
added
CR approved
Member
|
This PR is segfaulting for me on exit in this place: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1694, at least when shutting down with
leg_poser.jsrunning (which is the only case I've found so far that triggers the crash, it doesn't even log anything)Also tidies up some kinda cursed logic with pointers to global variables to just use defines instead.