Skip to content

fix(api): check gate group during analysis #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

fix(api): check gate group during analysis #7511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion engine/api/v2_repository_analyze.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
"github.com/ovh/cds/engine/api/database/gorpmapping"
"github.com/ovh/cds/engine/api/entity"
"github.com/ovh/cds/engine/api/event_v2"
"github.com/ovh/cds/engine/api/group"
"github.com/ovh/cds/engine/api/link"
"github.com/ovh/cds/engine/api/operation"
"github.com/ovh/cds/engine/api/project"
Expand Down Expand Up @@ -749,7 +750,7 @@ skipEntity:

}

//////////
// ////////

}

Expand Down Expand Up @@ -1612,6 +1613,19 @@ func Lint[T sdk.Lintable](ctx context.Context, db *gorp.DbMap, store cache.Store
if sameVCS && sameRepo && x.Repository != nil && x.Repository.InsecureSkipSignatureVerify {
err = append(err, sdk.NewErrorFrom(sdk.ErrWrongRequest, "workflow %s: parameter `insecure-skip-signature-verify`is not allowed if the workflow is defined on the same repository as `workflow.repository.name`. ", x.Name))
}
// Check gate user and group
for gateName, gateValue := range x.Gates {
for _, g := range gateValue.Reviewers.Groups {
if _, errG := group.LoadByName(ctx, db, g); errG != nil {
if sdk.ErrorIs(errG, sdk.ErrNotFound) {
err = append(err, sdk.NewErrorFrom(sdk.ErrWrongRequest, "workflow %s: gate %s: group %s not found", x.Name, gateName, g))
} else {
log.ErrorWithStackTrace(ctx, errG)
err = append(err, sdk.NewErrorFrom(sdk.ErrWrongRequest, "workflow %s: gate %s: unable to check group %s", x.Name, gateName, g))
}
}
}
}
for jobID, j := range x.Jobs {
// Check if worker model exists
if !strings.Contains(j.RunsOn.Model, "${{") && len(j.Steps) > 0 {
Expand Down