Skip to content

feat(enums): Key Wrap Type #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(enums): Key Wrap Type #53

wants to merge 2 commits into from

Conversation

ldesauw
Copy link
Contributor

@ldesauw ldesauw commented Sep 3, 2025

Add enum for Key Wrap Type, should fix #51

@ldesauw ldesauw requested a review from a team as a code owner September 3, 2025 08:45
@ldesauw ldesauw marked this pull request as draft September 3, 2025 09:57
@ldesauw ldesauw marked this pull request as ready for review September 3, 2025 09:58
gbahezre
gbahezre reviewed Sep 12, 2025
View reviewed changes
gbahezre
gbahezre reviewed Sep 12, 2025
View reviewed changes
gbahezre
gbahezre reviewed Sep 12, 2025
View reviewed changes
gbahezre
gbahezre reviewed Sep 12, 2025
View reviewed changes
gbahezre
gbahezre requested changes Sep 12, 2025
View reviewed changes
Copy link

@gbahezre gbahezre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check import/export payloads

@ldesauw ldesauw marked this pull request as draft September 12, 2025 09:22
@ldesauw ldesauw force-pushed the dev/ldesauw/key_wrap_type branch from 8cdb31a to 388e2ef Compare September 12, 2025 09:23
@phsym
Copy link
Collaborator

phsym commented Sep 12, 2025

@ldesauw don't forget to update the matrix of supported operations in the README

@ldesauw ldesauw force-pushed the dev/ldesauw/key_wrap_type branch from 388e2ef to 2a4ff75 Compare September 12, 2025 14:57
@ldesauw ldesauw force-pushed the dev/ldesauw/key_wrap_type branch from 2a4ff75 to fd39916 Compare September 12, 2025 14:59
@ldesauw
Copy link
Contributor Author

ldesauw commented Sep 12, 2025

Changed the AAD to kmip.Object as discussed.
Remove the version=1.4.. since the whole payload was added in KMIP 1.4
Updated the supported operation in the README's matrix

@ldesauw ldesauw marked this pull request as ready for review September 12, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbahezre gbahezre gbahezre requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of definition for Key Wrap Type Enumeration
3 participants
@ldesauw @phsym @gbahezre