Implement significant performance optimizations for json-strip-comments #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements advanced performance optimizations that deliver substantial speedups across all input types while maintaining full correctness and compatibility.
Performance Improvements
Benchmark Results:
Key Optimizations
has_potential_comments()
using efficient memchr variants based on enabled comment typesStringEscape
) and optimized state transitionsTechnical Details
The optimizations focus on the most impactful areas:
\"
and\\
escape handling/
characters to maintain error detection when comment types are disabledThese changes provide substantial performance gains while maintaining full backward compatibility and correctness.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.