perf: optimize state machine with Top state fast path #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the state machine by checking for the Top state first, providing significant performance improvements.
Changes
Restructured the main state machine loop in
strip_buf()
to:if *state == Top
first instead of using a match statementPerformance Results 🚀
Benchmark results show significant improvements:
Why This Works
The Top state is the most common state when processing JSON (most characters are neither in comments nor strings). By checking this state first with a simple equality check:
if *state == Top
branch more effectivelyThis is a simple but effective optimization that leverages the statistical properties of JSON files.
🤖 Generated with Claude Code