Skip to content

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 19, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings September 19, 2025 02:11
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Sep 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the TypeScript transformer to more comprehensively handle the removal of TypeScript-specific declarations during transformation. The change expands the filtering logic to remove both declare declarations and type-only declarations earlier in the transformation process.

Key changes:

  • Expanded the statement filtering logic to handle more TypeScript declaration types
  • Added handling for export declarations with type-only content
  • Improved coverage of declare and type-only declarations that should be removed

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 19, 2025
Copy link
Member Author

Dunqing commented Sep 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing force-pushed the 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-_569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0_ branch from 04666f6 to 0bdf3bd Compare September 19, 2025 02:12
@Dunqing Dunqing changed the title refactor(transformer/typescript): remove declare declarations and type-only declarations earlier" refactor(transformer/typescript): remove declare declarations and type-only declarations earlier Sep 19, 2025
@Dunqing Dunqing force-pushed the 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-_569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0_ branch from 0bdf3bd to c5c1672 Compare September 19, 2025 02:17
Copy link

codspeed-hq bot commented Sep 19, 2025

CodSpeed Instrumentation Performance Report

Merging #13908 will not alter performance

Comparing 09-19-refactor_transformer_typescript_remove_integer_10_readonly_81999_integer_10_readonly_0_integer_10_readonly_81952_array_readonly_readonly_-569jnrxghikls_0__bin_zsh_integer_10_readonly_0_array_readonly_integer_10_readonly_argc_0 (c5c1672) with main (f067159)

Summary

✅ 37 untouched

@Dunqing Dunqing marked this pull request as draft September 19, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant