Skip to content

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Sep 19, 2025

Tweaked the devcontainer options so that the commands work in the dev container.

Copy link
Member Author

sapphi-red commented Sep 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red changed the title chore: tweak devcontainer options chore(devcontainer): tweak devcontainer options Sep 19, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 19, 2025
@sapphi-red sapphi-red force-pushed the chore/tweak-devcontainer-options branch from d900f50 to 880a07c Compare September 20, 2025 13:17
@sapphi-red sapphi-red marked this pull request as ready for review September 20, 2025 13:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the devcontainer configuration to use a custom Dockerfile instead of a pre-built image and modifies the setup process for better tool management. The changes aim to ensure that all necessary commands work properly within the development container environment.

  • Replaced the pre-built Rust image with a custom Dockerfile-based build
  • Added a post-creation script to handle tool installation and setup
  • Updated environment and mount configurations for improved development workflow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.devcontainer/Dockerfile Adds custom Dockerfile with required system packages (just, cmake) and uv tool
.devcontainer/devcontainer.json Updates configuration to use custom Dockerfile, adds new features and mounts, changes post-creation command
.devcontainer/postCreateCommand.sh New script to handle cargo-binstall installation, npm package setup, and initialization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sapphi-red sapphi-red force-pushed the chore/tweak-devcontainer-options branch from 880a07c to 78f4481 Compare September 20, 2025 13:31
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
Copy link
Member

Boshen commented Sep 20, 2025

Merge activity

Tweaked the devcontainer options so that the commands work in the dev container.
@graphite-app graphite-app bot force-pushed the chore/tweak-devcontainer-options branch from 78f4481 to 51a2c30 Compare September 20, 2025 13:37
@graphite-app graphite-app bot merged commit 51a2c30 into main Sep 20, 2025
17 checks passed
@graphite-app graphite-app bot deleted the chore/tweak-devcontainer-options branch September 20, 2025 13:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants