Skip to content

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 21, 2025

This broke the linter ast nodes detector

Copy link
Contributor

graphite-app bot commented Sep 21, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-cfg Area - Control Flow Graph A-isolated-declarations Isolated Declarations A-editor Area - Editor and Language Server A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 21, 2025
@camc314 camc314 marked this pull request as ready for review September 21, 2025 13:55
@Copilot Copilot AI review requested due to automatic review settings September 21, 2025 13:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum supported Rust version (MSRV) to 1.88.0 and utilizes the new let-chains syntax feature that became stable in this version. The changes systematically replace nested if let statements with the more concise let-chains syntax throughout the codebase.

  • Updates MSRV to Rust 1.88.0 to enable let-chains syntax
  • Refactors nested conditional patterns to use let-chains for improved readability
  • Maintains the same logic while reducing code complexity and nesting levels

Reviewed Changes

Copilot reviewed 277 out of 277 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/oxc_transformer_plugins/src/replace_global_defines.rs Simplified nested if-let pattern in expression matching
crates/oxc_transformer/src/typescript/module.rs Combined multiple conditions using let-chains in declaration handling
crates/oxc_transformer/src/typescript/class.rs Refactored class field processing with let-chains
crates/oxc_transformer/src/plugins/styled_components.rs Simplified conditional checks in styled components processing
crates/oxc_transformer/src/options/babel/mod.rs Combined option checking logic using let-chains
Multiple other files Similar refactoring patterns applying let-chains syntax throughout the codebase

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codspeed-hq bot commented Sep 21, 2025

CodSpeed Instrumentation Performance Report

Merging #13977 will not alter performance

Comparing 09-21-chore_rust_msrv_1.88.0-2 (c778cba) with main (4ee94a3)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on main (c778cba) during the generation of this report, so 4ee94a3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dunqing
Copy link
Member

Dunqing commented Sep 21, 2025

If possible, I hope this stack of #13928 is merged first, as every PR in that stack may lead to conflicts with this PR.

Copy link
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oxc_language_server: ✔️

@camchenry
Copy link
Member

@Boshen I think we just need to run cargo lintgen? The syntax has changed slightly so some rules have reverted to a more conservative behavior, but we can fix that in a separate PR

@camc314 camc314 force-pushed the 09-21-chore_rust_msrv_1.88.0-2 branch from 9b7718c to 80b05ca Compare September 21, 2025 16:55
Copy link
Contributor

camc314 commented Sep 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314
Copy link
Contributor

camc314 commented Sep 21, 2025

i reran lintgen, some nodes changes from Some(AstTypesBitset) to none as our codegen isn't detecing if let AstKind::X = node.kind() && ..., but we can fix that in a followup

@camc314
Copy link
Contributor

camc314 commented Sep 21, 2025

If possible, I hope this stack of #13928 is merged first, as every PR in that stack may lead to conflicts with this PR.

@Dunqing lets merge that stack first, then i'll rebase this one

@camc314 camc314 marked this pull request as draft September 21, 2025 17:09
@camc314 camc314 force-pushed the 09-21-chore_rust_msrv_1.88.0-2 branch from 80b05ca to b666c38 Compare September 22, 2025 07:47
@camc314 camc314 marked this pull request as ready for review September 22, 2025 07:48
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 22, 2025
Copy link
Contributor

camc314 commented Sep 22, 2025

Merge activity

@camc314 camc314 force-pushed the 09-21-chore_rust_msrv_1.88.0-2 branch from b666c38 to 4352030 Compare September 22, 2025 13:59
This broke the linter ast nodes detector
@graphite-app graphite-app bot force-pushed the 09-21-chore_rust_msrv_1.88.0-2 branch from 4352030 to c778cba Compare September 22, 2025 14:04
@graphite-app graphite-app bot merged commit c778cba into main Sep 22, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 09-21-chore_rust_msrv_1.88.0-2 branch September 22, 2025 14:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-cfg Area - Control Flow Graph A-cli Area - CLI A-codegen Area - Code Generation A-editor Area - Editor and Language Server A-formatter Area - Formatter A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants