-
-
Notifications
You must be signed in to change notification settings - Fork 670
chore(rust): MSRV 1.88.0 #13977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rust): MSRV 1.88.0 #13977
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the minimum supported Rust version (MSRV) to 1.88.0 and utilizes the new let-chains syntax feature that became stable in this version. The changes systematically replace nested if let
statements with the more concise let-chains syntax throughout the codebase.
- Updates MSRV to Rust 1.88.0 to enable let-chains syntax
- Refactors nested conditional patterns to use let-chains for improved readability
- Maintains the same logic while reducing code complexity and nesting levels
Reviewed Changes
Copilot reviewed 277 out of 277 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
crates/oxc_transformer_plugins/src/replace_global_defines.rs | Simplified nested if-let pattern in expression matching |
crates/oxc_transformer/src/typescript/module.rs | Combined multiple conditions using let-chains in declaration handling |
crates/oxc_transformer/src/typescript/class.rs | Refactored class field processing with let-chains |
crates/oxc_transformer/src/plugins/styled_components.rs | Simplified conditional checks in styled components processing |
crates/oxc_transformer/src/options/babel/mod.rs | Combined option checking logic using let-chains |
Multiple other files | Similar refactoring patterns applying let-chains syntax throughout the codebase |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13977 will not alter performanceComparing Summary
Footnotes |
If possible, I hope this stack of #13928 is merged first, as every PR in that stack may lead to conflicts with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oxc_language_server: ✔️
@Boshen I think we just need to run cargo lintgen? The syntax has changed slightly so some rules have reverted to a more conservative behavior, but we can fix that in a separate PR |
9b7718c
to
80b05ca
Compare
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
i reran lintgen, some nodes changes from Some(AstTypesBitset) to none as our codegen isn't detecing |
80b05ca
to
b666c38
Compare
Merge activity
|
b666c38
to
4352030
Compare
This broke the linter ast nodes detector
4352030
to
c778cba
Compare
This broke the linter ast nodes detector